fischer
/
fischer-agentkit
1
0
Fork 0
Code Issues Pull Requests Actions 87 Packages Projects Releases Wiki Activity

refactor: remove all emoji from agentkit #16

Closed
fischer wants to merge 0 commits from refactor/remove-all-emoji into main
pull from: refactor/remove-all-emoji
merge into: fischer:main
Conversation 0 Commits - Files Changed -
fischer commented 2026-07-02 01:34:20 +08:00
Owner
Copy Link

Replace emoji characters across the entire codebase with stable alternatives.

Changes

  • Expert YAML avatars: emoji -> first character uppercase (CJK/ASCII)
  • Frontend banners/cards: emoji -> Ant Design Vue Outlined components (BankOutlined, AuditOutlined, TeamOutlined, CheckOutlined, etc.)
  • CLI status markers: checkmark/cross/warning -> OK/FAIL/WARN text labels + Rich colors
  • Terminal messages: emoji prefixes -> [WARN]/[PENDING]/[OK]/[REJECTED]/[TIMEOUT]
  • Bitable DB default: clipboard emoji -> "table" (aligns with models.py)
  • App.vue: remove emoji font fallback declarations
  • Test fixtures: emoji avatars -> first character letters
  • Gitea workflow: checkmark/cross -> [OK]/[FAIL]
  • plan_schema.py: emoji -> [Plan]/[WARN] text labels
  • chat.py/chatStream.ts: remove emoji prefix from board_started text

Type Changes

shell.avatar type upgraded from string to string | Component in useMessageRenderer.ts and MessageShell.vue to support both first-letter rendering and Ant Design icon components.

Verification

  • pytest tests/unit/: 798 passed, 117 skipped, 1 pre-existing failure (port config)
  • vitest tests/unit/: 133 passed, 1 pre-existing failure (localStorage isolation)
  • vue-tsc --noEmit: passed (0 errors)
  • Emoji scan: 0 hits in project source (all hits in .venv only)

Plan

docs/plans/2026-07-02-001-refactor-remove-all-emoji-plan.md

Replace emoji characters across the entire codebase with stable alternatives. ## Changes - **Expert YAML avatars**: emoji -> first character uppercase (CJK/ASCII) - **Frontend banners/cards**: emoji -> Ant Design Vue Outlined components (BankOutlined, AuditOutlined, TeamOutlined, CheckOutlined, etc.) - **CLI status markers**: checkmark/cross/warning -> OK/FAIL/WARN text labels + Rich colors - **Terminal messages**: emoji prefixes -> [WARN]/[PENDING]/[OK]/[REJECTED]/[TIMEOUT] - **Bitable DB default**: clipboard emoji -> "table" (aligns with models.py) - **App.vue**: remove emoji font fallback declarations - **Test fixtures**: emoji avatars -> first character letters - **Gitea workflow**: checkmark/cross -> [OK]/[FAIL] - **plan_schema.py**: emoji -> [Plan]/[WARN] text labels - **chat.py/chatStream.ts**: remove emoji prefix from board_started text ## Type Changes `shell.avatar` type upgraded from `string` to `string | Component` in `useMessageRenderer.ts` and `MessageShell.vue` to support both first-letter rendering and Ant Design icon components. ## Verification - pytest tests/unit/: 798 passed, 117 skipped, 1 pre-existing failure (port config) - vitest tests/unit/: 133 passed, 1 pre-existing failure (localStorage isolation) - vue-tsc --noEmit: passed (0 errors) - Emoji scan: 0 hits in project source (all hits in .venv only) ## Plan docs/plans/2026-07-02-001-refactor-remove-all-emoji-plan.md
fischer added 2 commits 2026-07-02 01:34:20 +08:00
36b0296730 fix: 私董会数据持久化修复 + emoji 移除计划 
- 修复 board_started/expert_speech/round_summary/board_concluded 事件持久化
- 添加 is_board 标记到会话列表和详情接口
- 实现 restoreBoardStateFromMessages 从持久化消息恢复 boardState
- 添加 ChatSidebar 私董会徽章
- 添加 emoji 移除计划文档 (docs/plans/2026-07-02-001)
Deploy to Production / deploy (push) Waiting to run Details
Test / backend-test (push) Waiting to run Details
Test / frontend-unit (push) Waiting to run Details
Test / api-e2e (push) Waiting to run Details
Test / frontend-e2e (push) Waiting to run Details
Test / backend-test (pull_request) Has been cancelled Details
Test / frontend-unit (pull_request) Has been cancelled Details
Test / api-e2e (pull_request) Has been cancelled Details
Test / frontend-e2e (pull_request) Has been cancelled Details
78a7faa17b refactor: remove all emoji from agentkit 
Replace emoji across codebase: YAML avatars -> first char, frontend banners -> Ant Design Vue components, CLI status -> OK/FAIL/WARN labels, terminal -> [WARN]/[OK]/[PENDING], Bitable DB default -> table, App.vue font cleanup, test fixtures -> first char letters. shell.avatar type upgraded to string | Component.
fischer closed this pull request 2026-07-02 23:04:18 +08:00
Some checks failed
Deploy to Production / deploy (push) Waiting to run
Details
Test / backend-test (push) Waiting to run
Details
Test / frontend-unit (push) Waiting to run
Details
Test / api-e2e (push) Waiting to run
Details
Test / frontend-e2e (push) Waiting to run
Details
Test / backend-test (pull_request) Has been cancelled
Details
Test / frontend-unit (pull_request) Has been cancelled
Details
Test / api-e2e (pull_request) Has been cancelled
Details
Test / frontend-e2e (pull_request) Has been cancelled
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fischer/fischer-agentkit#16
No description provided.
Delete Branch "refactor/remove-all-emoji"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?