fischer-agentkit

Commit Graph

Author	SHA1	Message	Date
chiguyong	786f921c5e	feat(core): spec review gate - pause PLAN_EXEC for user review (U8, R8) Add a spec review gate to PlanExecEngine that pauses execution after the first Spec is generated, awaiting the user's confirm/reject decision. On approval execution continues; on rejection the engine replans (capped at 2 replans); on 30-min timeout the Spec is parked (not failed) so the user can resume later. - spec_manager: add parked status + park()/resume() methods - plan_exec_engine: add spec_review_handler param, wire gate into both execute_stream and _execute_loop with replan cap, emit spec_review_request/spec_review_reply events, handle timeout to park - chat.py: whitelist new events, add spec_review_reply WS handler, wire _spec_review_handler closure (30-min timeout), cleanup on disconnect - portal.py: persist spec_review_id/decision/feedback for page reload - tests: 20 unit tests covering happy path, rejection/replan, timeout, cancellation, backward compat, handler errors, park/resume round-trips	2026-07-03 15:20:38 +08:00
chiguyong	200174c5c7	feat: SQLite persistence, verification loop, spec-driven execution Phase 2 of architecture optimization (U5/U6/U9): - U5: SqliteConversationStore with WAL mode + LRU cache (1000 convs) Replaces in-memory ConversationStore in portal.py Data survives server restarts (ref: Codex Thread persistence) - U6: VerificationLoop with verify/verify_and_retry Default commands: pytest + ruff check ReActEngine integration via verification_enabled flag New run_tests tool for LLM to invoke verification - U9: SpecManager for plan-as-contract (ref: Qoder Quest Mode) Plans persisted to .agentkit/specs/{spec_id}.yaml API: GET/PUT /api/v1/specs, POST /api/v1/specs/{id}/confirm PlanExecEngine emits spec_created event after plan generation Also fixes: portal skill_name routing, app.py SessionManager guard, test_telemetry CostAwareRouter removal, test_compression_config fixture	2026-06-17 10:45:20 +08:00

Author

SHA1

Message

Date

chiguyong

786f921c5e

feat(core): spec review gate - pause PLAN_EXEC for user review (U8, R8)

Add a spec review gate to PlanExecEngine that pauses execution after the
first Spec is generated, awaiting the user's confirm/reject decision.
On approval execution continues; on rejection the engine replans (capped
at 2 replans); on 30-min timeout the Spec is parked (not failed) so the
user can resume later.

- spec_manager: add parked status + park()/resume() methods
- plan_exec_engine: add spec_review_handler param, wire gate into both
  execute_stream and _execute_loop with replan cap, emit
  spec_review_request/spec_review_reply events, handle timeout to park
- chat.py: whitelist new events, add spec_review_reply WS handler,
  wire _spec_review_handler closure (30-min timeout), cleanup on disconnect
- portal.py: persist spec_review_id/decision/feedback for page reload
- tests: 20 unit tests covering happy path, rejection/replan, timeout,
  cancellation, backward compat, handler errors, park/resume round-trips

2026-07-03 15:20:38 +08:00

chiguyong

200174c5c7

feat: SQLite persistence, verification loop, spec-driven execution

Phase 2 of architecture optimization (U5/U6/U9):

- U5: SqliteConversationStore with WAL mode + LRU cache (1000 convs)
  Replaces in-memory ConversationStore in portal.py
  Data survives server restarts (ref: Codex Thread persistence)
- U6: VerificationLoop with verify/verify_and_retry
  Default commands: pytest + ruff check
  ReActEngine integration via verification_enabled flag
  New run_tests tool for LLM to invoke verification
- U9: SpecManager for plan-as-contract (ref: Qoder Quest Mode)
  Plans persisted to .agentkit/specs/{spec_id}.yaml
  API: GET/PUT /api/v1/specs, POST /api/v1/specs/{id}/confirm
  PlanExecEngine emits spec_created event after plan generation

Also fixes: portal skill_name routing, app.py SessionManager guard,
test_telemetry CostAwareRouter removal, test_compression_config fixture

2026-06-17 10:45:20 +08:00

2 Commits