fischer-agentkit

Commit Graph

Author	SHA1	Message	Date
chiguyong	d7ca6e8065	fix(review): W1 ServerConfig from_dict wiring, W3 internal kwargs filter, N3 status docstring Test / backend-test (pull_request) Has been cancelled Details Test / frontend-unit (pull_request) Has been cancelled Details Test / api-e2e (pull_request) Has been cancelled Details Test / frontend-e2e (pull_request) Has been cancelled Details Code review fixes for Wave 1: - W1: ServerConfig.from_dict now wires prompt_cache/streaming/verification sections from YAML to constructor (previously these params existed but were never read) - W3: Tool._validate_input filters _-prefixed kwargs (e.g. _skip_dangerous_check) before jsonschema.validate, preventing additionalProperties:false schemas from rejecting internal control parameters - N3: ReActResult.status docstring now lists "empty_fallback" and "verify_failed" Added test test_internal_kwargs_underscore_prefixed_skipped_by_validation for W3.	2026-06-29 21:58:40 +08:00
chiguyong	c66a7773b5	feat(U1): G3 工具调用 schema 校验 - base.py 新增 ToolValidationError(error_code/details)与 _validate_input - safe_execute 在 execute 前用 jsonschema.validate 校验 kwargs - input_schema=None 跳过校验保持向后兼容 - _execute_tool 优先捕获 ToolValidationError 保留 error_code - function_tool._infer_schema 修复 VAR_KEYWORD/VAR_POSITIONAL 误入 schema - test_tool_schema_validation.py 覆盖 R8-R10	2026-06-29 20:34:14 +08:00

Author

SHA1

Message

Date

chiguyong

d7ca6e8065

fix(review): W1 ServerConfig from_dict wiring, W3 internal kwargs filter, N3 status docstring

Test / backend-test (pull_request) Has been cancelled Details

Test / frontend-unit (pull_request) Has been cancelled Details

Test / api-e2e (pull_request) Has been cancelled Details

Test / frontend-e2e (pull_request) Has been cancelled Details

Code review fixes for Wave 1:
- W1: ServerConfig.from_dict now wires prompt_cache/streaming/verification sections
  from YAML to constructor (previously these params existed but were never read)
- W3: Tool._validate_input filters _-prefixed kwargs (e.g. _skip_dangerous_check)
  before jsonschema.validate, preventing additionalProperties:false schemas from
  rejecting internal control parameters
- N3: ReActResult.status docstring now lists "empty_fallback" and "verify_failed"

Added test test_internal_kwargs_underscore_prefixed_skipped_by_validation for W3.

2026-06-29 21:58:40 +08:00

chiguyong

c66a7773b5

feat(U1): G3 工具调用 schema 校验

- base.py 新增 ToolValidationError(error_code/details)与 _validate_input
- safe_execute 在 execute 前用 jsonschema.validate 校验 kwargs
- input_schema=None 跳过校验保持向后兼容
- _execute_tool 优先捕获 ToolValidationError 保留 error_code
- function_tool._infer_schema 修复 VAR_KEYWORD/VAR_POSITIONAL 误入 schema
- test_tool_schema_validation.py 覆盖 R8-R10

2026-06-29 20:34:14 +08:00

2 Commits