2 Commits

Author	SHA1	Message	Date
chiguyong	92fc38de7e	fix(review): Wave 3 code review fixes ... P1: bash/shell tool name mismatch. PhasePolicy whitelist used "bash" but ShellTool registers as "shell". The bash_command_filter was dead code (never matched the real tool name). Fixed in phase.py whitelist, react.py filter check, agentkit.yaml config, and all tests. P1: AdvancePhaseTool missing import in tools/__init__.py. Was in __all__ but never imported. Added the import. P2: chat.py phase policy error message echoed verbatim to WS client. Truncated to 200 chars to match nearby error paths and avoid leaking config internals. P2: policy_from_config rebuilt PhasePolicy 3x via full-field copy. Replaced with dataclasses.replace() so new PhasePolicy fields are not silently dropped in future reconstructions. ce-code-review (mode:agent) step of LFG pipeline.	2026-06-30 05:08:03 +08:00
chiguyong	abf758fa9c	feat(U2): G6 PhaseState + PhasePolicy + ServerConfig.plan_exec ... - PhaseState enum (PLANNING/BUILDING/VERIFICATION/DELIVERY) with next_of/from_string - PhasePolicy dataclass with whitelist + bash_command_filter + auto_advance_after_steps - default_policy() factory — KTD5 whitelist matching R24 (Planning: search/read_file; Building: write_file; Delivery: wildcard) - bash_command_filter blocks rm/mv/cp/>/>> in PLANNING/VERIFICATION phases - policy_from_config() parses plan_exec YAML section (R26) with override merge - ServerConfig.plan_exec field + from_dict parsing (extends Wave 1/2 pattern) - agentkit.yaml gains commented plan_exec section (opt-in) - 37 unit tests covering PhaseState, default_policy, is_tool_allowed, bash filter, config parsing, and ServerConfig integration	2026-06-29 23:58:56 +08:00