2 Commits

Author	SHA1	Message	Date
chiguyong	92fc38de7e	fix(review): Wave 3 code review fixes ... P1: bash/shell tool name mismatch. PhasePolicy whitelist used "bash" but ShellTool registers as "shell". The bash_command_filter was dead code (never matched the real tool name). Fixed in phase.py whitelist, react.py filter check, agentkit.yaml config, and all tests. P1: AdvancePhaseTool missing import in tools/__init__.py. Was in __all__ but never imported. Added the import. P2: chat.py phase policy error message echoed verbatim to WS client. Truncated to 200 chars to match nearby error paths and avoid leaking config internals. P2: policy_from_config rebuilt PhasePolicy 3x via full-field copy. Replaced with dataclasses.replace() so new PhasePolicy fields are not silently dropped in future reconstructions. ce-code-review (mode:agent) step of LFG pipeline.	2026-06-30 05:08:03 +08:00
chiguyong	c0a44b413b	feat(U3): G6 AdvancePhaseTool + ReActEngine phase enforcement ... - AdvancePhaseTool calls engine.advance_phase(), returns new phase or error - ReActEngine.__init__ accepts phase_policy param (None = no enforcement, backward compat) - _current_phase + _steps_in_phase fields track state machine - advance_phase() transitions PLANNING → BUILDING → VERIFICATION → DELIVERY - _check_phase_permission() returns structured error dict if tool blocked - _execute_tool checks phase before dispatch (advance_phase name bypasses) - Auto-advance safety net via _maybe_auto_advance() + auto_advance_after_steps - Phase reset in reset() method - 27 unit tests covering characterization, permission, transitions, auto-advance, tool integration	2026-06-30 00:07:58 +08:00