fischer
/
fischer-agentkit
1
0
Fork 0
Code Issues Pull Requests Actions 87 Packages Projects Releases Wiki Activity

refactor: tech debt Wave 3+4 (tools/skills/mcp/rag/calendar/auth/cli/quality/channels/telemetry/session/bus/documents Any 治理) #11

Merged
fischer merged 2 commits from refactor/tech-debt-wave-3-4 into main 2026-07-01 08:08:36 +08:00
Conversation 0 Commits 2 Files Changed 81 +415 -473
fischer commented 2026-07-01 04:54:29 +08:00
Owner
Copy Link

Tech Debt Cleanup Wave 3+4: tools/skills/mcp/rag_platform/calendar/auth/cli/quality/channels/telemetry/session/bus/documents Any 治理

Summary

承接 PR #10 (Wave 1+2) 的后续工作，本 PR 完成 Wave 3（tools/ + skills/ Any 治理）和 Wave 4（mcp/ + rag_platform/ + calendar/ + server/auth/ + cli/ + quality/ + channels/ + telemetry/ + session/ + bus/ + documents/ Any 治理），共消除 470 处 Any，覆盖 81 个文件。

Commits

  1. 57f4ee9 — refactor: remove Any from tools/ + skills/ (220 sites) — 34 文件
  2. 1f4f54b — refactor: remove Any from Wave 4 modules (250 sites) — 47 文件

Wave 3: tools/ + skills/ Any 治理（220 处 / 34 文件）

tools/（146 处 / 27 文件）

  • 热点：bitable_tool.py(20)、computer_use.py(16)、schema_tools.py(14)
  • 策略：dict[str, object] > object > 移除未使用 Any import

skills/（74 处 / 7 文件）

  • 热点：geo_pipeline.py(23)、base.py(18)、pipeline.py(13)
  • 额外修复 3 个预先存在的 F401 错误

Wave 4: 其余模块 Any 治理（250 处 / 47 文件）

治理范围

模块 文件数 Any 消除数 热点
mcp/ 4 40 transport.py(43行)
rag_platform/ 9 32 tasks.py(22)
calendar/ 4 31 outlook_provider.py(39行)
server/auth/ 7 29 dependencies.py(18)
cli/ 3 28 admin.py(16)
quality/ 4 16 alignment.py(9)
channels/ 4 12 feishu.py(4)
telemetry/ 2 12 tracer.py(11)
session/ 3 11 models.py(6)
bus/ 4 9 message.py(5)
documents/ 3 7 excel_renderer.py(3)

安全敏感区域

server/auth/ 严格仅改类型注解，未触碰任何认证逻辑。所有 dict[str, Any] → dict[str, object]，Callable[..., Any] → Callable[..., object]。

治理策略

  1. dict[str, object]（主要）：所有 JSON-shaped dict
  2. object：外部依赖对象参数（Redis client、httpx client、openpyxl worksheet、OTel tracer/span 等）
  3. **kwargs: object：替换 **kwargs: Any
  4. Callable[..., object] / Awaitable[object]：回调类型
  5. TYPE_CHECKING import + 字符串注解：避免循环引用（如 MultiServerMCPClient）
  6. 移除未使用的 from typing import Any

Testing Notes

测试范围 结果
tools/ + skills/ + cli/ + quality/ + channels/ 577 passed, 0 failed
mcp/ + auth/ + calendar/ 288 passed, 0 failed
rag_platform/test_retrieval.py 11 failed（基线一致，预先存在的测试顺序污染）

总计 865 passed, 0 回归

ruff: 13 errors（基线 20 errors，净减 7，0 新增）

Post-Deploy Monitoring & Validation

No additional operational monitoring required — 本 PR 是纯类型注解修改，不改变运行时行为：

  • Python 注解默认惰性求值，类型改变不影响执行
  • server/auth/ 仅改类型注解，未触碰认证逻辑

Known Residuals

无。本 PR 完成了 Wave 3+4 全部计划工作。剩余技术债务：

  • except Exception 残留 ~150 处（主要是框架边界 + 设计意图保留，属合理残留）
  • Any 残留接近 0（剩余可能在 server/config/、server/middleware/、server/services/ 等未扫描目录）

Compound Engineering

# Tech Debt Cleanup Wave 3+4: tools/skills/mcp/rag_platform/calendar/auth/cli/quality/channels/telemetry/session/bus/documents Any 治理 ## Summary 承接 PR #10 (Wave 1+2) 的后续工作，本 PR 完成 Wave 3（`tools/` + `skills/` Any 治理）和 Wave 4（`mcp/` + `rag_platform/` + `calendar/` + `server/auth/` + `cli/` + `quality/` + `channels/` + `telemetry/` + `session/` + `bus/` + `documents/` Any 治理），共消除 **470 处 Any**，覆盖 **81 个文件**。 ## Commits 1. `57f4ee9` — `refactor: remove Any from tools/ + skills/ (220 sites)` — 34 文件 2. `1f4f54b` — `refactor: remove Any from Wave 4 modules (250 sites)` — 47 文件 ## Wave 3: tools/ + skills/ Any 治理（220 处 / 34 文件） ### tools/（146 处 / 27 文件） - 热点：`bitable_tool.py`(20)、`computer_use.py`(16)、`schema_tools.py`(14) - 策略：`dict[str, object]` > `object` > 移除未使用 `Any` import ### skills/（74 处 / 7 文件） - 热点：`geo_pipeline.py`(23)、`base.py`(18)、`pipeline.py`(13) - 额外修复 3 个预先存在的 F401 错误 ## Wave 4: 其余模块 Any 治理（250 处 / 47 文件） ### 治理范围 | 模块 | 文件数 | Any 消除数 | 热点 | |------|--------|-----------|------| | `mcp/` | 4 | 40 | `transport.py`(43行) | | `rag_platform/` | 9 | 32 | `tasks.py`(22) | | `calendar/` | 4 | 31 | `outlook_provider.py`(39行) | | `server/auth/` | 7 | 29 | `dependencies.py`(18) | | `cli/` | 3 | 28 | `admin.py`(16) | | `quality/` | 4 | 16 | `alignment.py`(9) | | `channels/` | 4 | 12 | `feishu.py`(4) | | `telemetry/` | 2 | 12 | `tracer.py`(11) | | `session/` | 3 | 11 | `models.py`(6) | | `bus/` | 4 | 9 | `message.py`(5) | | `documents/` | 3 | 7 | `excel_renderer.py`(3) | ### 安全敏感区域 `server/auth/` 严格仅改类型注解，未触碰任何认证逻辑。所有 `dict[str, Any]` → `dict[str, object]`，`Callable[..., Any]` → `Callable[..., object]`。 ## 治理策略 1. **`dict[str, object]`**（主要）：所有 JSON-shaped dict 2. **`object`**：外部依赖对象参数（Redis client、httpx client、openpyxl worksheet、OTel tracer/span 等） 3. **`**kwargs: object`**：替换 `**kwargs: Any` 4. **`Callable[..., object]`** / **`Awaitable[object]`**：回调类型 5. **TYPE_CHECKING import + 字符串注解**：避免循环引用（如 `MultiServerMCPClient`） 6. **移除未使用的 `from typing import Any`** ## Testing Notes | 测试范围 | 结果 | |---------|------| | `tools/` + `skills/` + `cli/` + `quality/` + `channels/` | **577 passed, 0 failed** | | `mcp/` + `auth/` + `calendar/` | **288 passed, 0 failed** | | `rag_platform/test_retrieval.py` | 11 failed（**基线一致**，预先存在的测试顺序污染） | **总计 865 passed, 0 回归** **ruff**: 13 errors（基线 20 errors，净减 7，0 新增） ## Post-Deploy Monitoring & Validation **No additional operational monitoring required** — 本 PR 是纯类型注解修改，不改变运行时行为： - Python 注解默认惰性求值，类型改变不影响执行 - `server/auth/` 仅改类型注解，未触碰认证逻辑 ## Known Residuals 无。本 PR 完成了 Wave 3+4 全部计划工作。剩余技术债务： - `except Exception` 残留 ~150 处（主要是框架边界 + 设计意图保留，属合理残留） - `Any` 残留接近 0（剩余可能在 `server/config/`、`server/middleware/`、`server/services/` 等未扫描目录） --- [![Compound Engineering](https://img.shields.io/badge/Built_with-Compound_Engineering-6366f1)](https://github.com/EveryInc/compound-engineering-plugin)
fischer added 2 commits 2026-07-01 04:54:29 +08:00
57f4ee9ac0 refactor: remove Any from tools/ + skills/ (220 sites) 
Wave 3 Any 治理:
- tools/ 146 sites: bitable_tool(20), computer_use(16), schema_tools(14), shell(7), builtin(7), file_read(8), calendar_tool(8), web_crawl(6), computer_use_recorder(6), ask_human(5), baidu_search(5), web_search(5), base(5), memory_tool(3), skill_search(3), function_tool(3), skill_install(3), document_tool(4), mcp_tool(4), output_parser(2), advance_phase(2), search(2), composition(2), agent_tool(2), headroom_retrieve(2), terminal_session(1), registry(1)
- skills/ 74 sites: geo_pipeline(23), base(18), pipeline(13), schema(8), skill_detail(6), skill_md(6) + 3 F401 fixes

Strategy: dict[str,object] > object > TYPE_CHECKING Protocol
Tests: 577 passed, 0 regressions
ruff: 13 errors (all pre-existing, 0 new)
Test / backend-test (pull_request) Has been cancelled Details
Test / frontend-unit (pull_request) Has been cancelled Details
Test / api-e2e (pull_request) Has been cancelled Details
Test / frontend-e2e (pull_request) Has been cancelled Details
1f4f54b073 refactor: remove Any from Wave 4 modules (250 sites)
fischer merged commit c005642851 into main 2026-07-01 08:08:36 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fischer/fischer-agentkit#11
No description provided.
Delete Branch "refactor/tech-debt-wave-3-4"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?