fischer
/
fischer-agentkit
1
0
Fork 0
Code Issues Pull Requests Actions 87 Packages Projects Releases Wiki Activity

refactor: remove all emoji from source code #20

Merged
fischer merged 3 commits from refactor/remove-all-emoji into main 2026-07-03 02:46:41 +08:00
Conversation 0 Commits 3 Files Changed 13 +394 -61
fischer commented 2026-07-03 02:38:59 +08:00
Owner
Copy Link

Summary

Replace all emoji/glyph characters with text-based alternatives per project convention.

Changes

U1: Frontend icons (Ant Design Vue Outlined)

  • ReviewResultCard.vue: statusIcon returns Component types (CheckOutlined/CloseOutlined/ReloadOutlined) rendered via <component :is>
  • useMessageRenderer.ts: shell avatars use ApartmentOutlined/CheckOutlined/CloseOutlined/WarningOutlined

U2: CLI/shell text labels

  • cli/chat.py: OK/FAIL/RUN/--/>> with Rich color tags
  • scripts/deploy.sh: [OK]/[FAIL]
  • scripts/dev-start.sh: OK/FAIL/.. with ANSI colors
  • .gitea/workflows/deploy.yml: [OK]

U3: Docstring ASCII art

  • session_service.py: Unicode box-drawing arrows replaced with ASCII (->/|/v)
  • capability_metrics.py: > replaced ▸

U5: Pre-commit guard + style guide

  • scripts/check-no-emoji.sh: scans for literal emoji and escaped unicode sequences
  • .pre-commit-config.yaml: local hook agentkit-no-emoji
  • docs/solutions/style/no-emoji-style-guide.md: KTD1-3 replacement strategies, Unicode range table

Verification

  • bash scripts/check-no-emoji.sh exits 0
  • TypeScript typecheck passed
  • pytest: 2294 passed (1 pre-existing failure unrelated to this change)
  • vitest: 180 passed (1 pre-existing failure unrelated to this change)

Plan

Closes: docs/plans/2026-07-02-001-refactor-remove-all-emoji-plan.md

## Summary Replace all emoji/glyph characters with text-based alternatives per project convention. ## Changes ### U1: Frontend icons (Ant Design Vue Outlined) - `ReviewResultCard.vue`: `statusIcon` returns Component types (`CheckOutlined`/`CloseOutlined`/`ReloadOutlined`) rendered via `<component :is>` - `useMessageRenderer.ts`: shell avatars use `ApartmentOutlined`/`CheckOutlined`/`CloseOutlined`/`WarningOutlined` ### U2: CLI/shell text labels - `cli/chat.py`: `OK`/`FAIL`/`RUN`/`--`/`>>` with Rich color tags - `scripts/deploy.sh`: `[OK]`/`[FAIL]` - `scripts/dev-start.sh`: `OK`/`FAIL`/`..` with ANSI colors - `.gitea/workflows/deploy.yml`: `[OK]` ### U3: Docstring ASCII art - `session_service.py`: Unicode box-drawing arrows replaced with ASCII (`->`/`|`/`v`) - `capability_metrics.py`: `>` replaced `▸` ### U5: Pre-commit guard + style guide - `scripts/check-no-emoji.sh`: scans for literal emoji and escaped unicode sequences - `.pre-commit-config.yaml`: local hook `agentkit-no-emoji` - `docs/solutions/style/no-emoji-style-guide.md`: KTD1-3 replacement strategies, Unicode range table ## Verification - `bash scripts/check-no-emoji.sh` exits 0 - TypeScript typecheck passed - pytest: 2294 passed (1 pre-existing failure unrelated to this change) - vitest: 180 passed (1 pre-existing failure unrelated to this change) ## Plan Closes: docs/plans/2026-07-02-001-refactor-remove-all-emoji-plan.md
fischer added 2 commits 2026-07-03 02:38:59 +08:00
6123b8feb2 docs(plan): update emoji removal plan after ce-doc-review 
Apply ce-doc-review findings:
- P0: AE1 updated to plain text (no icon), ReviewResultCard.vue added to U2
- P0: useMessageRenderer.ts line numbers corrected (203/262 done, 286/307/328 pending)
- P0: U5 lint regex expanded (Geometric Shapes + Arrows + escaped unicode)
- P1: scripts/dev-start.sh, deploy.sh, .gitea/workflows/deploy.yml added to U3
- P1: U5 simplified to pre-commit grep + style doc (no ESLint/ruff custom rules)
- P2: status updated to in-progress with progress tracking
- safe_auto: MessageShell.vue path fixed, batch count 4->5, commits 5->5-6
Test / backend-test (pull_request) Has been cancelled Details
Test / frontend-unit (pull_request) Has been cancelled Details
Test / api-e2e (pull_request) Has been cancelled Details
Test / frontend-e2e (pull_request) Has been cancelled Details
4085d7634f refactor: remove all emoji from source code 
Replace emoji/glyph characters with:
- Ant Design Vue Outlined icons (frontend: ReviewResultCard, useMessageRenderer)
- Text labels with ANSI colors (CLI: chat.py, shell scripts)
- ASCII art (session_service.py docstring)

Add pre-commit guard (scripts/check-no-emoji.sh) and style guide
(docs/solutions/style/no-emoji-style-guide.md) to prevent regression.

Closes: emoji removal plan (docs/plans/2026-07-02-001)
fischer added 1 commit 2026-07-03 02:46:17 +08:00
Test / backend-test (pull_request) Has been cancelled Details
Test / frontend-unit (pull_request) Has been cancelled Details
Test / api-e2e (pull_request) Has been cancelled Details
Test / frontend-e2e (pull_request) Has been cancelled Details
dd5584192f docs(compound): document emoji removal pattern and learnings 
Captures the LFG pipeline execution experience: Ant Design icon
replacement pattern, text label conventions, Unicode range exclusions
for the pre-commit guard, and escaped-unicode detection approach.
fischer merged commit 2296d0b209 into main 2026-07-03 02:46:41 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fischer/fischer-agentkit#20
No description provided.
Delete Branch "refactor/remove-all-emoji"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?