3fdd29d152
build(bitable): rebuild frontend index.html for JS hash alignment
...
Test / backend-test (pull_request) Has been cancelled
Details
Test / frontend-unit (pull_request) Has been cancelled
Details
Test / api-e2e (pull_request) Has been cancelled
Details
Test / frontend-e2e (pull_request) Has been cancelled
Details
Rebuild index.html after U1-U6 frontend changes. JS bundle hash updated
(index-CHtvprqX.js -> index-agwA6wam.js) to match new build output.
CI runs unit/e2e only and does not rebuild static assets, so the committed
hash must match the bundled JS.
2026-07-04 00:39:24 +08:00
0f4a418408
docs(review): record residual review findings for feat/bitable-enhancement
2026-07-04 00:29:02 +08:00
137bda0361
refactor(bitable): simplify code after ce-simplify-code pass
...
Behavior-preserving simplifications (net -22 lines):
- useResponsiveBreakpoint: remove createHandler factory, share single sync fn
- RecordDetailDrawer: remove isEditable wrapper, call isFieldEditable directly
- ViewConfigPanel: merge duplicate saveGrouping/saveConditionalFormat into saveU5Config
- groupingRulesUtils: use Array.find instead of for-loop, simplify Number.isFinite check
- GroupingEditor: simplify filter callback to single-expression arrow
Verified: typecheck + build:frontend + ruff all pass.
Refs: ce-simplify-code (LFG Step 3)
2026-07-04 00:28:28 +08:00
229dc0b2f3
feat(bitable): U6 R15a BitableTool 4 new actions + DELETE /views endpoint
...
Extend BitableTool from 6 to 10 actions (create_view, update_view,
update_field, delete_view) and add the DELETE /views/{view_id} backend
endpoint with 404-before-403 ownership, 409 last-view protection, and
X-Internal-Token passthrough (KTD11).
Backend:
- repository.py: add delete_view() — DELETE row by view_id, returns rowcount > 0
- service.py: add LastViewDeletionError domain exception + delete_view()
with last-view guard (siblings <= 1 → raise → route maps to 409)
- routes/bitable.py: add DELETE /views/{view_id} (204 No Content),
404-before-403 ownership pattern, 409 on LastViewDeletionError,
X-Internal-Token passthrough via require_bitable_auth
- tools/bitable_tool.py: add 4 new actions (_create_view, _update_view,
_update_field, _delete_view), register in BOTH handlers dict AND
input_schema.action.enum (KTD10 — 10 actions each)
Frontend:
- api/bitable.ts: add deleteView(viewId): Promise<void>
- stores/bitable.ts: add deleteView action — removes from local state,
switches to first remaining view if active was deleted, 409 warning
- ViewSwitcher.vue: add delete button (a-popconfirm "确认删除此视图？"),
hidden when views.length <= 1 (preempt last-view 409)
- BitableFileDetailView.vue: handle @delete event from ViewSwitcher
Tests:
- test_routes.py: 6 new DELETE /views tests (204, 404 missing, 404
non-owner, 409 last-view, internal-token passthrough, internal-token 404)
- test_bitable_tool.py: 13 new tests (action count = 10, handlers = 10,
4 action happy paths, missing-field errors, 409 last-view, R3/R4
config parity, X-Internal-Token passthrough on all 4 new actions)
- e2e/bitable-agent-parity.spec.ts: 10 scenarios (P1-P10) covering
delete button visibility, popconfirm, 204/409/404 flows, tab removal,
view switch after delete, create view adds tab
Verification:
- ruff check: all files pass
- pytest: 62 passed, 12 pre-existing failures (unchanged from e931fbee931fbe
2026-07-03 23:13:46 +08:00
e931fbef2d
feat(bitable): U5 R4 grouping (max 3 fields) + conditional formatting (7 operators)
...
- GroupingEditor: multi-select field picker (max 3), per-level direction
toggle, reorder buttons, "已知限制：不支持跨分组多选" note, empty state
- ConditionalFormatEditor: per-rule enable/field/operator/value/color/bold,
8 color keys, WCAG 1.4.1 bold default true, first-match-wins footer legend
- BitableGrid: unified section rendering (grouped/ungrouped via single
vxe-grid declaration), group headers as separate divs (CF only on data
cells), CF via row-config.className, multi-grid instance map for refresh
- groupingRulesUtils: pure functions for CF matching (7 operators), group
tree builder, SUM/AVG aggregation, CSS var mappers, self-check on load
- view_config.py: Pydantic v2 validation (MAX_GROUP_BY_FIELDS=3, 7
operators, 8 color keys, extra="forbid" on sub-models)
- routes/bitable.py: validate_view_config on PATCH (HTTP 422 on error)
- stores/bitable.ts: updateViewConfig action (merges U5 sub-keys, preserves
filters/sort/hidden_fields)
- ViewConfigPanel: grouping + conditional-format tabs
- E2E: 8 scenarios (G1-G8: single/multi grouping, collapse/expand, CF
equals/between, combined, aggregation)
- Tests: 54 unit tests (19 grouping + 35 CF), 2 PG-marked skipped
2026-07-03 22:33:18 +08:00
f280627da1
feat(bitable): U4 view type switcher with 5 types (grid enabled, others disabled)
...
- Add viewSwitcherUtils.ts (5 view types metadata: label/icon/disabled/tooltip)
- Refactor ViewSwitcher: button -> dropdown with 5 types, disabled items show "规划中" tooltip
- Update BitableFileDetailView.handleCreateView to accept viewType parameter (no more hardcoded grid)
- Bind :creating=viewCreating to ViewSwitcher for loading/disabled state during POST
- Extend store createView + API createView to pass view_type field (already in prior commits)
- Add loading/disabled state on create button to prevent duplicate clicks
- Extend e2e/bitable-view.spec.ts with 5 view type scenarios (E1-E5)
Closes R3 (P0): view type selection in UI, backend already supports view_type.
Refs: docs/plans/2026-07-03-001-feat-bitable-p0-ux-and-agent-parity-plan.md U4
2026-07-03 21:43:51 +08:00
5baaeb489d
feat(bitable): U3 record detail drawer with full field type rendering
...
- Add RecordDetailDrawer.vue (480px/640px drawer, sticky header, full field type render)
- Add recordDrawerUtils.ts (value formatter, attachment/image extractors, drawer width calc)
- Add currentRecord state + openRecordDetail/closeRecordDetail/fetchRecordDetail actions to store
- Wire BitableGrid row click to open drawer
- Add e2e/bitable-record-drawer.spec.ts with 7 scenarios
- Loading/Error/404/empty states use U1 LoadingState/ErrorState per Open Question
- useResponsiveBreakpoint consumed: isMobile -> 100vw full-screen overlay
- user-owned fields editable, agent-owned fields read-only, upsert preserves agent columns
Closes R2 (P0): grid row click -> detail drawer with all field types visualized.
Refs: docs/plans/2026-07-03-001-feat-bitable-p0-ux-and-agent-parity-plan.md U3
2026-07-03 15:57:33 +08:00
f0c993a0d9
feat(bitable): U2 inline field configuration in column header menu
...
- Add InlineFieldConfigurator.vue (inline panel reusing FieldConfigForm logic)
- Add fieldRenderUtils.ts (type conversion compatibility check)
- Refactor ColumnHeaderMenu: edit -> inline expand, batch -> open FieldManagePanel
- Integrate InlineFieldConfigurator in BitableGrid header slot
- Add batch-management banner to FieldManagePanel
- Add submitting loading state to prevent duplicate clicks
- Extend e2e/bitable-field-ops.spec.ts with inline edit scenarios
Closes R1 (P0): column header menu inline edit, no more drawer jump.
Refs: docs/plans/2026-07-03-001-feat-bitable-p0-ux-and-agent-parity-plan.md U2
2026-07-03 15:12:17 +08:00
e1cf073693
feat(bitable): U1 add design token system + vxe-table dependency declaration
...
- Add bitable-tokens.css with 4 token categories (color/spacing/radius/font/drawer-width)
- Add FieldTypeIcon.vue mapping 9 field types to Ant Design Outlined icons
- Add useResponsiveBreakpoint composable (768/1024/1440 breakpoints)
- Add LoadingState (skeleton) and ErrorState (inline alert + retry) components
- Token化 9 bitable components/views (replace hardcoded hex with var())
- Declare vxe-table dependency explicitly (resolve ghost dependency)
- Upgrade SelectDisplay chip palette to 8-color token with WCAG AA contrast
Phase 1 foundation for Phase 2 UX work (U2-U5).
Refs: docs/plans/2026-07-03-001-feat-bitable-p0-ux-and-agent-parity-plan.md U1
2026-07-03 14:40:57 +08:00
96ccca3d87
docs(bitable-p0): add implementation plan for P0 UX polish + agent parity
...
ce-plan Deep plan (6 Implementation Units, 3 delivery phases):
- Phase 1: U1 R5 design token system + vxe-table dependency declaration
- Phase 2: U2-U5 R1-R4 frontend UX (inline field config, record drawer,
view type switcher, grouping + conditional formatting)
- Phase 3: U6 R15a BitableTool 4 new actions + DELETE /views endpoint
11 KTDs covering: CSS token layer, vxe-table ghost dependency fix,
inline field configurator (hybrid vxe-table slot + custom component),
record detail drawer (single column 480/640px), view type dropdown
with disabled states, grouping + conditional format in View.config
with backend Pydantic validation, BitableTool action registration
(handlers dict + input_schema enum), X-Internal-Token ownership
semantics, 3-phase delivery with config schema freeze for parallel U6.
Phase 5.3 headless ce-doc-review (5 reviewers, 14 findings):
- Applied 2 safe_auto (U6 verification method, U5→U6 dependency)
- Applied 2 gated_auto (input_schema enum step, color_token→color_key)
- Applied 5 P1 manual fixes (backend config validation, X-Internal-Token
ownership, grouping+CF combo state, LoadingState/ErrorState justification,
R3/R4 backend assumption verification)
- 8 P2/P3 manual findings appended to Open Questions
Origin: docs/brainstorms/2026-07-03-bitable-comparative-evaluation-requirements.md
2026-07-03 13:49:57 +08:00
f8927d1749
docs(bitable-eval): apply ce-doc-review best-judgment fixes (20 gated_auto + 12 manual)
...
ce-doc-review（7 reviewers, 39 raw findings → 32 actionable + 3 FYI 经合成管道），
用户选择"自动用最佳判断处理"路径。本提交应用全部 20 个 gated_auto 修复，并把
12 个 manual findings 追加到 Outstanding Questions 的 From 2026-07-03 review 子节。
主要修复：
- 修正 BitableTool 动作清单：实际为 create_table/import_excel/import_database/
collect_api/upsert_records/query_records（原文 4/6 错），消除 R15a 范围误判
- R15a 从 B 线提升至 P0（4 reviewers 独立标记的优先级矛盾——B 线"non-blocking"
与"agent 对等最高优先级子项"自相矛盾）
- G23 闭合路径标注（R15c 路径 (a)/(b)）
- 默认字段类型未来 user/datetime 标注（Inventory + G6）
- R3 后端依赖标注（POST /views schema 扩展）
- 视图删除端点补 P0 验收标准（R15a 验收 + 前端 deleteView 方法）
- vxe-table 幽灵依赖标注（package.json 未声明，靠主仓 hoisting）
- create_field 动作标注为必需（R8 17 新类型需 agent 能批量建字段）
- R15 测试映射拆分为 R15a/R15b/R15c 三行
- R8 验收矩阵补 PII/XSS/auto-number 写保护列 + schema V3 迁移成本估算
- R15c 安全要求补 SSRF/认证/凭据加密 + 端点访问控制
- 横切验收标准补 WCAG AA 可访问性 + 空状态要求
- R8 矩阵范围标注（覆盖 P1，非 P0）
Open Questions 新增 12 个 manual findings（ce-plan 阶段决策）：
- user 字段用户模型
- C 先行优先级策略的实证依据
- 并发编辑 UX 策略
- 加载/错误状态统一模式
- 条件格式规则构建器 UX 形态
- 分组交互细节
- 响应式断点定义
- R2 记录详情抽屉宽度
- vxe-table 容量上限评估
- R13 仪表盘图表库 buy-vs-build
- 禁用态视图类型路线图
- schema V3 双向关联回滚策略
文件：docs/brainstorms/2026-07-03-bitable-comparative-evaluation-requirements.md
（107 insertions, 31 deletions）
2026-07-03 13:32:07 +08:00
e9821a3b7f
docs(bitable): add comparative evaluation requirements with ce-code-review P1 fixes
...
新增三向对比评估需求文档（agentkit bitable vs Twenty vs 飞书），并应用 ce-code-review
产出的全部 P1 缺口修复（共 9 项）：
- P1-1: R8 字段类型计数对齐 16+1=17（KD6 与 R8 同步）
- P1-2: 新增 R8 字段类型验收矩阵（17 行表，含 V2->V3 迁移列）
- P1-3: KTD7 引用具体文件 formula/parser.py 替代裸引用
- P1-4: R-ID 命名空间冲突，加日期前缀 2026-06-29-R1..R5
- P1-5: created-time 统一为 datetime（通用类型 + 默认字段使用 datetime）
- P1-6: 新增 P0 验收标准段落（R1-R5 Given/When/Then）
- P1-7: 新增测试策略段落 + 测试文件映射表（R1-R5、R8、R15）
- P1-8: R15 拆解为 R15a/R15b/R15c + 新增 Agent 对等评估方法段落
- P1-9: R4 补充后端扩展（group_by/conditional_formatting schema）+ agent 对等说明
同时包含 2 项 gated_auto 修复：
- 组件计数 14 -> 15
- 移除文档中的全部 emoji，替换为 [OK]
ce-code-review run-id: 20260703-123134-c7c2b2ea
2026-07-03 12:59:41 +08:00
chiguyong